Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init pkg/connector #103

Merged
merged 3 commits into from
Nov 29, 2024
Merged

init pkg/connector #103

merged 3 commits into from
Nov 29, 2024

Conversation

rnons
Copy link

@rnons rnons commented Nov 28, 2024

  • login works
  • create portals on connect

@rnons rnons requested a review from tulir November 28, 2024 13:23
tulir
tulir approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@tulir tulir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's fine to work directly on the v2 branch too btw

pkg/connector/connector.go Outdated Show resolved Hide resolved
@rnons rnons merged commit 74a4761 into v2 Nov 29, 2024
6 of 9 checks passed
@rnons rnons deleted the rnons/connector branch November 29, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tulir tulir tulir approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnons @tulir