Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add More Timelines #1714

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Add More Timelines #1714

merged 1 commit into from
Jan 27, 2025

Conversation

nikhilbadyal
Copy link
Contributor

The current setup has a significant gap in its timeline options, jumping from 1 week to 1 month and then directly to 1 year. Introducing a 90-day (quarterly) period would bridge this gap effectively. A 90-day timeline is crucial, as it aligns with how people typically evaluate goals and progress on a quarterly basis. This addition would provide a more comprehensive range of timeframes for users to review and plan.

@zachgoll
Copy link
Collaborator

@nikhilbadyal agreed! While we're here, would you mind also adding the periods I had mentioned in this comment? I think that would get us to a pretty comprehensive set of options:

#1701 (comment)

@nikhilbadyal nikhilbadyal force-pushed the 3m-period branch 2 times, most recently from 84f703f to 307d97c Compare January 27, 2025 17:03
@nikhilbadyal nikhilbadyal changed the title Add last 3 months period Add More Timelines Jan 27, 2025
@nikhilbadyal
Copy link
Contributor Author

@zachgoll You can review now.

Copy link
Collaborator

@zachgoll zachgoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We may have to tweak based on user feedback, but I think this is a good base to go off for now.

@zachgoll zachgoll merged commit 2a20257 into maybe-finance:main Jan 27, 2025
5 checks passed
@nikhilbadyal nikhilbadyal deleted the 3m-period branch January 28, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants