🐛 - fix: fix a bug that could cause the DataRangeInput component not …

…to respond to value changes if the updated value was empty
maykinmedia · Jan 30, 2025 · 0998ba2 · 0998ba2
1 parent cd653c5
commit 0998ba2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/components/form/dateinput/dateinput.tsx b/src/components/form/dateinput/dateinput.tsx
@@ -134,6 +134,7 @@ export const DateInput: React.FC<DateInputProps> = ({
   // Update sanitizedValuesState.
   useEffect(() => {
     if (!value) {
+      setSanitizedValuesState(undefined);
       return;
     }
     const date = value2Date(value);
@@ -261,9 +262,11 @@ export const DateInput: React.FC<DateInputProps> = ({
         dispatchEvent(dateString);
         setIsPristine(false);
       } else {
+        if (isPristine) {
+          return;
+        }
         // Date is invalid after previous valid value, dispatch "".
         dispatchEvent("");
-        setIsPristine(false);
       }
     },
     [sanitizedValuesState, isPristine, dispatchEvent],

diff --git a/src/components/form/daterangeinput/daterangeinput.tsx b/src/components/form/daterangeinput/daterangeinput.tsx
@@ -104,6 +104,7 @@ export const DateRangeInput: React.FC<DateRangeInputProps> = ({
       .map(date2DateString);
 
     if (!dates?.length || (dates?.length && dates?.length < 2)) {
+      setValuesState(undefined);
       return;
     }
-Original file line number
+Diff line change
@@ Expand Up @@
           .map(date2DateString);
         if (!dates?.length || (dates?.length && dates?.length < 2)) {
+          setValuesState(undefined);
           return;
         }
@@ Expand Down @@