Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/compatibility #166

Merged
merged 2 commits into from
Jan 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@maykin-ui/admin-ui",
"version": "0.0.42",
"version": "0.0.43",
"description": "",
"scripts": {
"create-component": "./bin/create_component.sh",
Expand Down
14 changes: 8 additions & 6 deletions src/components/form/form/form.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,12 @@ const playFormComponent = async ({
const firstName = canvas.getByLabelText("First name");
const lastName = canvas.getByLabelText("Last name");
const age = canvas.getByLabelText("Age");
const schoolYear = canvas.getByLabelText("Select school year");
const schoolYear = canvas.getByLabelText("Select school year", {
exact: false,
});
const address = canvas.getByLabelText("Address");
const address_addition = canvas.getByLabelText("Address (addition)");
const dayOfMonth = canvas.getByLabelText("day of month");
const dateOfBirth = canvas.getByLabelText("Date of birth", { exact: false });
const english = canvas.getByLabelText("English");
const math = canvas.getByLabelText("Math");
const yes = canvas.getByLabelText("Yes");
Expand Down Expand Up @@ -116,10 +118,10 @@ const playFormComponent = async ({
typedResults ? ["Keizersgracht 117", 2] : ["Keizersgracht 117", "2"],
);

await userEvent.clear(dayOfMonth);
await userEvent.type(dayOfMonth, "15092023", { delay: 60 });
await userEvent.type(dayOfMonth, "{enter}");
await expect(dayOfMonth).toHaveValue("15");
await userEvent.clear(dateOfBirth);
await userEvent.type(dateOfBirth, "15092023", { delay: 60 });
await userEvent.type(dateOfBirth, "{enter}");
await expect(dateOfBirth).toHaveValue("15");
await expectLogToBe(
canvasElement,
"date_of_birth",
Expand Down
2 changes: 1 addition & 1 deletion src/components/form/select/select.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ export const Select: React.FC<SelectProps> = ({
name={name}
defaultValue={selectedOptionValue}
hidden={true}
aria-label={label}
aria-label="" // Intentionally left blank
form={form}
>
{(selectedOptionValue && (
Expand Down
Loading