Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#663] Record manager can assign co-reviewers to new list #664

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

SilviaAmAm
Copy link
Collaborator

Fixes #663

Initially, only the reviewer could assign co-reviewers to a ready-to-review list. Then, it was allowed that the record manager also could assign them. Now, the record manager can also assign co-reviewers to a new list.
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.69%. Comparing base (f4a8f2f) to head (269e8fe).

Files with missing lines Patch % Lines
...c/openarchiefbeheer/destruction/api/permissions.py 80.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f4a8f2f) and HEAD (269e8fe). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f4a8f2f) HEAD (269e8fe)
storybook 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #664       +/-   ##
===========================================
- Coverage   87.43%   69.69%   -17.75%     
===========================================
  Files          93      210      +117     
  Lines        2324     6055     +3731     
  Branches      647      564       -83     
===========================================
+ Hits         2032     4220     +2188     
- Misses        292     1835     +1543     
Flag Coverage Δ
backend 91.51% <83.33%> (?)
jest 33.02% <ø> (ø)
storybook ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SilviaAmAm SilviaAmAm merged commit 7dda84c into main Feb 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Foutmelding (klopt niet) maar actie wordt wel uitgevoerd.
3 participants