Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 #667 - test: add (failing) tests for ordering #671

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

svenvandescheur
Copy link
Contributor

@svenvandescheur svenvandescheur commented Feb 3, 2025

@SilviaAmAm this add failing tests for ordering, can you have a look at fixing this?

Fixes #667

@svenvandescheur svenvandescheur changed the title 🧪 #669 - test: add (failing) tests for ordering 🧪 #667 - test: add (failing) tests for ordering Feb 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 52.94118% with 24 lines in your changes missing coverage. Please review.

Project coverage is 89.66%. Comparing base (f4a8f2f) to head (611d3d4).

Files with missing lines Patch % Lines
.../src/openarchiefbeheer/destruction/api/backends.py 35.13% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
- Coverage   89.97%   89.66%   -0.32%     
==========================================
  Files         210      210              
  Lines        6116     6164      +48     
  Branches      647      647              
==========================================
+ Hits         5503     5527      +24     
- Misses        613      637      +24     
Flag Coverage Δ
backend 91.01% <52.94%> (-0.52%) ⬇️
jest 33.02% <ø> (ø)
storybook 85.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@svenvandescheur svenvandescheur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) 👍

@SilviaAmAm SilviaAmAm marked this pull request as ready for review February 4, 2025 12:47
@SilviaAmAm SilviaAmAm merged commit 15c4db6 into main Feb 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting seems to be broken in various places
3 participants