Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 - fix: fix session expired code #674

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

Xaohs
Copy link
Contributor

@Xaohs Xaohs commented Feb 5, 2025

closes #673

@Xaohs Xaohs requested review from SilviaAmAm and svenvandescheur and removed request for SilviaAmAm February 5, 2025 16:03
@Xaohs Xaohs marked this pull request as ready for review February 5, 2025 16:03
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (3635ee9) to head (6a8570b).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
+ Coverage   89.66%   90.24%   +0.58%     
==========================================
  Files         210      210              
  Lines        6171     6211      +40     
  Branches      647      669      +22     
==========================================
+ Hits         5533     5605      +72     
+ Misses        638      606      -32     
Flag Coverage Δ
backend 91.00% <ø> (ø)
jest 32.54% <100.00%> (-0.48%) ⬇️
storybook 85.77% <100.00%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@svenvandescheur svenvandescheur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second though, we can only filter on just the keys right?, so something like:

  const flatten = Object.entries(errors || {})
     .filter([key, value]) => !["key", "code"].includes(key))
     .map([key, value]) => value)
     .flat()
     ```

@Xaohs Xaohs requested a review from svenvandescheur February 6, 2025 14:53
@svenvandescheur svenvandescheur merged commit 93d10b7 into main Feb 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatting session expired error message
3 participants