Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#516] Refactor user checks #681

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

SilviaAmAm
Copy link
Collaborator

Fixes #516

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.35%. Comparing base (93d10b7) to head (b5d9dd7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #681      +/-   ##
==========================================
+ Coverage   90.24%   90.35%   +0.11%     
==========================================
  Files         210      211       +1     
  Lines        6211     6231      +20     
  Branches      669      675       +6     
==========================================
+ Hits         5605     5630      +25     
+ Misses        606      601       -5     
Flag Coverage Δ
backend 91.05% <100.00%> (+0.05%) ⬆️
jest 32.73% <93.75%> (+0.19%) ⬆️
storybook 85.99% <87.50%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@svenvandescheur svenvandescheur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some ideas

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how this cleans up the serializers :)

@SilviaAmAm SilviaAmAm force-pushed the refactor/516-refactor-user-checks branch 2 times, most recently from 14bea48 to a9f5d93 Compare February 7, 2025 12:21
@SilviaAmAm SilviaAmAm force-pushed the refactor/516-refactor-user-checks branch from a9f5d93 to b5d9dd7 Compare February 7, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor where user checks are performed
3 participants