Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added vectorized distance calculations #4

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Added vectorized distance calculations #4

wants to merge 7 commits into from

Conversation

reinisindans
Copy link

using scipy.spatial.distance for efficient distance calculations. Execution time reduced ~10x.

@reinisindans
Added vectorized distance calculations
534c99d 
using scipy.spatial.distance for efficient distance calculations. Execution time reduced ~10x.
mblackgeo
mblackgeo requested changes Mar 29, 2024
View reviewed changes
Copy link
Owner

@mblackgeo mblackgeo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, didn't seem to get a notification about this PR from github.

Thanks for the PR 🚀
Please could you sync with master so we can let the CI run, thanks

@reinisindans
Copy link
Author

Update from master done.

Thanks for the library :)

@mblackgeo
Copy link
Owner

No worries, thanks. Please could you take a look at the CI failure?

@reinisindans reinisindans requested a review from mblackgeo June 12, 2024 11:47
@mblackgeo
Copy link
Owner

Thanks for the update, could you take a look at fixing the formatting with black please?

@reinisindans
fix: formatted with Black
857f484 
formatted file kde.py with black formatter
@reinisindans
Copy link
Author

Formatted with black. Hope this works.

@reinisindans
fix: formatted with Black
89adfa4 
formatted file kde.py with black formatter
@mblackgeo
Copy link
Owner

Still seems to be failing, please can you try using make format? Then verify with make lint (which is what the CI is doing), thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mblackgeo mblackgeo Awaiting requested review from mblackgeo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reinisindans @mblackgeo