-
Notifications
You must be signed in to change notification settings - Fork 78
Switch to martinohmann difflib fork and colorize diff output #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #423 +/- ##
==========================================
- Coverage 54.52% 54.51% -0.01%
==========================================
Files 53 53
Lines 4457 4459 +2
==========================================
+ Hits 2430 2431 +1
- Misses 1886 1887 +1
Partials 141 141 ☔ View full report in Codecov by Sentry. |
This pull request is stale because it has been open for 30 days without activity. |
keepalive |
Add a --color flag to the apply, diff and edit commands to control whether to output color. Valid options are "auto" and "never". (The martinohmann/difflib library doesn't seem to support forcing color output unfortunately.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! I can't immediately see why, but I tested manually, and it looks like gmailctl diff --color=never
still colorizes the output. Could you double-check? Maybe I'm missing something.
Sorry about that. I fixed it so label diffs respect Also, would you want a |
@kpengboy I think this looks good enough, thanks! |
This would at least be a partial solution to #371.
I did not add the colorization to the cfgtest output, but I wonder if I should.