Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sound Event Geometry Update Bug #45

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

mbsantiago
Copy link
Owner

When annotating, updating a sound event's geometry caused it to visually revert to its original state. This was due to a type mismatch between

soundevent.data.Feature (returned by the update function) and the expected whombat.schemas.Feature in the client's validation layer. The difference stems from the recent addition of terms to soundevent.

This PR resolves the issue by correctly casting soundevent.data.Feature to whombat.schemas.Feature before sending the data back to the client. This ensures the validation passes and the updated geometry persists.

@mbsantiago mbsantiago merged commit 38c8e21 into main Dec 4, 2024
6 checks passed
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.47%. Comparing base (351ff06) to head (e9b4e54).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
back/src/whombat/api/sound_events.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   66.47%   66.47%           
=======================================
  Files         179      179           
  Lines        8367     8367           
=======================================
  Hits         5562     5562           
  Misses       2805     2805           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant