Merge branch '1.23' into 1.x

mcneel · Aug 20, 2024 · 274baca · 274baca
2 parents f68844e + a2b2ee2
commit 274baca
Show file tree

Hide file tree

Showing 17 changed files with 73 additions and 8 deletions.
diff --git a/art/gh-icons/comps/AddAngularDimension.png b/art/gh-icons/comps/AddAngularDimension.png
diff --git a/art/gh-icons/comps/AddArcLengthDimension.png b/art/gh-icons/comps/AddArcLengthDimension.png
diff --git a/art/gh-icons/comps/AddDiameterDimension.png b/art/gh-icons/comps/AddDiameterDimension.png
diff --git a/art/gh-icons/comps/AddRadialDimension.png b/art/gh-icons/comps/AddRadialDimension.png
diff --git a/art/gh-icons/comps/src/AddArcLengthDimension.afdesign b/art/gh-icons/comps/src/AddArcLengthDimension.afdesign
diff --git a/art/gh-icons/comps/src/AddDiameterDimension.afdesign b/art/gh-icons/comps/src/AddDiameterDimension.afdesign
diff --git a/art/gh-icons/comps/src/AddRadialDimension.afdesign b/art/gh-icons/comps/src/AddRadialDimension.afdesign
diff --git a/docs/_data/components.json b/docs/_data/components.json
@@ -5567,6 +5567,18 @@
     "until": null, 
     "uuid": "0dbe67e7-7d8e-41f9-85b0-139c0b7f1745"
   }, 
+  {
+    "desc": "Given an arc, it adds an arc length dimension to the given View", 
+    "iconsrc": "/static/images/GH/AddArcLengthDimension.png", 
+    "icontag": null, 
+    "panel": "Annotate", 
+    "since": "1.23", 
+    "tab": "Revit", 
+    "title": "Add Arc Length Dimension", 
+    "typename": "AddArcLengthDimension", 
+    "until": null, 
+    "uuid": "3fd260d4-1e8d-4c03-89d0-3d7256c19520"
+  }, 
   {
     "desc": "Given a point, it adds an area tag to the given Area Plan", 
     "iconsrc": "/static/images/GH/AddAreaTag.png", 
@@ -5603,6 +5615,18 @@
     "until": null, 
     "uuid": "5a94ea62-3c27-4e48-b885-c98218264981"
   }, 
+  {
+    "desc": "Given an arc referece, it adds a diameter dimension to the given View", 
+    "iconsrc": "/static/images/GH/AddDiameterDimension.png", 
+    "icontag": null, 
+    "panel": "Annotate", 
+    "since": "1.23", 
+    "tab": "Revit", 
+    "title": "Add Diameter Dimension", 
+    "typename": "AddDiameterDimension", 
+    "until": null, 
+    "uuid": "00d46c47-e8ae-4ec2-98f8-77f2542c26f9"
+  }, 
   {
     "desc": "Given a point, it adds a category tag to the given View", 
     "iconsrc": "/static/images/GH/AddElementTagByCategory.png", 
@@ -5639,6 +5663,30 @@
     "until": null, 
     "uuid": "11424062-b5da-4ba9-8b98-4886829ec67f"
   }, 
+  {
+    "desc": "Given a line, it adds a linear dimension to the given View", 
+    "iconsrc": "/static/images/GH/AddLinearDimension.png", 
+    "icontag": null, 
+    "panel": "Annotate", 
+    "since": "1.23", 
+    "tab": "Revit", 
+    "title": "Add Linear Dimension", 
+    "typename": "AddLinearDimension", 
+    "until": null, 
+    "uuid": "414fe2a9-74f7-4f73-9833-c04c7a362c9e"
+  }, 
+  {
+    "desc": "Given an arc referece, it adds a radial dimension to the given View", 
+    "iconsrc": "/static/images/GH/AddRadialDimension.png", 
+    "icontag": null, 
+    "panel": "Annotate", 
+    "since": "1.23", 
+    "tab": "Revit", 
+    "title": "Add Radial Dimension", 
+    "typename": "AddRadialDimension", 
+    "until": null, 
+    "uuid": "194e7de0-5049-4bda-a0fd-322c0f62aa47"
+  }, 
   {
     "desc": "Given a profile, it adds a region to the given View", 
     "iconsrc": "/static/images/GH/AddRegion.png", 

diff --git a/docs/pages/_en/1.0/reference/release-notes.md b/docs/pages/_en/1.0/reference/release-notes.md
@@ -17,6 +17,10 @@ group: Deployment & Configs
 
 {% include ltr/release_header_next.html title="Upcoming Changes" note=rc_release_notes %}
 
+{% include ltr/release-header.html title="v1.23" version="v1.23.8998.19322" time="08/20/2024" %}
+
+- Includes all changes under 1.23 RC releases listed below
+
 {% include ltr/release-header.html title="v1.23 RC3" version="v1.23.8984.17382" pre_release=true time="08/06/2024" %}
 
 - Update Code-Signing Certificate
@@ -27,10 +31,10 @@ group: Deployment & Configs
 
 {% include ltr/release-header.html title="v1.23 RC1" version="v1.23.8962.17381" pre_release=true time="07/15/2024" %}
 
-- Added 'Add Linear Dimension' in Revit 2025 or above.
-- Added 'Add Radial Dimension' in Revit 2025 or above.
-- Added 'Add Diameter Dimension' in Revit 2025 or above.
-- Added 'Add Arc Length Dimension' in Revit 2025 or above.
+- Added {% include ltr/comp.html uuid='414fe2a9' %} in Revit 2025 or above.
+- Added {% include ltr/comp.html uuid='194e7de0' %} in Revit 2025 or above.
+- Added {% include ltr/comp.html uuid='00d46c47' %} in Revit 2025 or above.
+- Added {% include ltr/comp.html uuid='3fd260d4' %} in Revit 2025 or above.
 - Added TopoSolid by Points in Revit 2024 or above.
 
 {% include ltr/release-header.html title="v1.22" version="v1.22.8962.17228" time="07/15/2024" %}

diff --git a/docs/static/images/GH/AddAngularDimension.png b/docs/static/images/GH/AddAngularDimension.png
diff --git a/docs/static/images/GH/AddArcLengthDimension.png b/docs/static/images/GH/AddArcLengthDimension.png
diff --git a/docs/static/images/GH/AddDiameterDimension.png b/docs/static/images/GH/AddDiameterDimension.png
diff --git a/docs/static/images/GH/AddRadialDimension.png b/docs/static/images/GH/AddRadialDimension.png
diff --git a/src/RhinoInside.Revit.GH/Components/Annotations/AddAngularDimension.cs b/src/RhinoInside.Revit.GH/Components/Annotations/AddAngularDimension.cs
@@ -117,7 +117,7 @@ protected override void TrySolveInstance(IGH_DataAccess DA)
       );
     }
 
-    bool Reuse(ARDB.Dimension dimension, ARDB.View view, ARDB.Arc arc, IList<ARDB.Reference> references, ARDB.DimensionType type)
+    static bool Reuse(ARDB.Dimension dimension, ARDB.View view, ARDB.Arc arc, IList<ARDB.Reference> references, ARDB.DimensionType type)
     {
       if (dimension is null) return false;
       if (dimension.OwnerViewId != view.Id) return false;
@@ -140,7 +140,7 @@ bool Reuse(ARDB.Dimension dimension, ARDB.View view, ARDB.Arc arc, IList<ARDB.Re
       return true;
     }
 
-    ARDB.Dimension Reconstruct(ARDB.Dimension dimension, ARDB.View view, ARDB.Arc arc, IList<ARDB.Reference> references, ARDB.DimensionType type)
+    static ARDB.Dimension Reconstruct(ARDB.Dimension dimension, ARDB.View view, ARDB.Arc arc, IList<ARDB.Reference> references, ARDB.DimensionType type)
     {
       if (!Reuse(dimension, view, arc, references, type))
       {

diff --git a/src/RhinoInside.Revit.GH/Components/Annotations/AddArcLengthDimension.cs b/src/RhinoInside.Revit.GH/Components/Annotations/AddArcLengthDimension.cs
@@ -118,7 +118,7 @@ protected override void TrySolveInstance(IGH_DataAccess DA)
       );
     }
 
-    bool Reuse(ARDB.Dimension dimension, ARDB.View view, ARDB.Arc arc, IList<ARDB.Reference> references, ARDB.DimensionType type)
+    static bool Reuse(ARDB.Dimension dimension, ARDB.View view, ARDB.Arc arc, IList<ARDB.Reference> references, ARDB.DimensionType type)
     {
       if (dimension is null) return false;
       if (dimension.OwnerViewId != view.Id) return false;
@@ -141,7 +141,7 @@ bool Reuse(ARDB.Dimension dimension, ARDB.View view, ARDB.Arc arc, IList<ARDB.Re
       return true;
     }
 
-    ARDB.Dimension Reconstruct(ARDB.Dimension dimension, ARDB.View view, ARDB.Arc arc, IList<ARDB.Reference> references, ARDB.DimensionType type)
+    static ARDB.Dimension Reconstruct(ARDB.Dimension dimension, ARDB.View view, ARDB.Arc arc, IList<ARDB.Reference> references, ARDB.DimensionType type)
     {
       if (!Reuse(dimension, view, arc, references, type))
       {

diff --git a/src/RhinoInside.Revit.GH/Properties/Resources.resx b/src/RhinoInside.Revit.GH/Properties/Resources.resx
@@ -1636,4 +1636,16 @@
   <data name="ViewWorkPlane" type="System.Resources.ResXFileRef, System.Windows.Forms">
     <value>..\..\..\art\gh-icons\comps\ViewWorkPlane.png;System.Drawing.Bitmap, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a</value>
   </data>
+  <data name="AddArcLengthDimension" type="System.Resources.ResXFileRef, System.Windows.Forms">
+    <value>..\..\..\art\gh-icons\comps\AddArcLengthDimension.png;System.Drawing.Bitmap, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a</value>
+  </data>
+  <data name="AddAngularDimension" type="System.Resources.ResXFileRef, System.Windows.Forms">
+    <value>..\..\..\art\gh-icons\comps\AddAngularDimension.png;System.Drawing.Bitmap, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a</value>
+  </data>
+  <data name="AddRadialDimension" type="System.Resources.ResXFileRef, System.Windows.Forms">
+    <value>..\..\..\art\gh-icons\comps\AddRadialDimension.png;System.Drawing.Bitmap, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a</value>
+  </data>
+  <data name="AddDiameterDimension" type="System.Resources.ResXFileRef, System.Windows.Forms">
+    <value>..\..\..\art\gh-icons\comps\AddDiameterDimension.png;System.Drawing.Bitmap, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a</value>
+  </data>
 </root>
diff --git a/src/RhinoInside.Revit.GH/RhinoInside.Revit.GH.csproj b/src/RhinoInside.Revit.GH/RhinoInside.Revit.GH.csproj
@@ -6,6 +6,7 @@
   <PropertyGroup>
     <AssemblyName>RhinoInside.Revit.GH</AssemblyName>
     <RootNamespace>RhinoInside.Revit.GH</RootNamespace>
+    <NoWarn>IDE0057</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>