Merge pull request #1204 from mcneel/1.25

Fix on `Types.Roof.CurtainGrids` property.
mcneel · Oct 24, 2024 · aa72c1a · aa72c1a
2 parents 8bfd64d + b116322
commit aa72c1a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/RhinoInside.Revit.GH/Types/HostObjects/CurtainGridLine.cs b/src/RhinoInside.Revit.GH/Types/HostObjects/CurtainGridLine.cs
@@ -59,7 +59,7 @@ public override Plane Location
       }
     }
 
-    public override Curve Curve => Value?.AllSegmentCurves is ARDB.CurveArray segments ? Curve.JoinCurves(segments.ToCurveMany())[0] : default;
+    public override Curve Curve => Value?.AllSegmentCurves is ARDB.CurveArray segments ? Curve.JoinCurves(segments.ToCurveMany()).FirstOrDefault() : default;
     #endregion
   }
 }
diff --git a/src/RhinoInside.Revit.GH/Types/HostObjects/Roof.cs b/src/RhinoInside.Revit.GH/Types/HostObjects/Roof.cs
@@ -88,12 +88,12 @@ public IList<CurtainGrid> CurtainGrids
         {
           case ARDB.ExtrusionRoof extrusionRoof:
             return extrusionRoof.CurtainGrids is ARDB.CurtainGridSet extrusionGrids ?
-              extrusionGrids.Cast<ARDB.CurtainGrid>().Select((x, i) => new CurtainGrid(this, x, i)).ToArray() :
+              extrusionGrids.Cast<ARDB.CurtainGrid>().Where(x => x.GetCurtainCells().Any(c => !c.CurveLoops.IsEmpty)).Select((x, i) => new CurtainGrid(this, x, i)).ToArray() :
               new CurtainGrid[] { };
 
           case ARDB.FootPrintRoof footPrintRoof:
             return footPrintRoof.CurtainGrids is ARDB.CurtainGridSet footPrintGrids ?
-              footPrintGrids.Cast<ARDB.CurtainGrid>().Select((x, i) => new CurtainGrid(this, x, i)).ToArray() :
+              footPrintGrids.Cast<ARDB.CurtainGrid>().Where(x => x.GetCurtainCells().Any(c => !c.CurveLoops.IsEmpty)).Select((x, i) => new CurtainGrid(this, x, i)).ToArray() :
               new CurtainGrid[] { };
         }