Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] AddPoint with attributes #665

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

StudioWEngineers
Copy link

Adds three additional overloads of AddPoint for Python, mirroring the existing AddPoint1, AddPoint2 and AddPoint4 which
do not take object attributes.

Minimal tests have been added.

Bindings have been added to Python only.

Implements #664.

@fraguada
Copy link
Member

fraguada commented Jan 8, 2025

Thanks for the contribution! I checked and everything seems ok.

@fraguada fraguada merged commit c7e1345 into mcneel:dev Jan 8, 2025
44 checks passed
@StudioWEngineers StudioWEngineers deleted the AddPoint_with_attributes branch January 8, 2025 12:35
@StudioWEngineers
Copy link
Author

Thanks for reviewing and accepting @fraguada!

One thing that I may forgot: updating docs and stubs. Actually I am not sure if this is done automatically or some files shall be updated by hand after changing the binding code.

For instance:

https://github.com/mcneel/rhino3dm/blob/2be29689d99a9b8c0b511e3646cbe38a0bad6a81/docs/python/api/_sources/File3dmObjectTable.rst.txt?plain=1#L20C4-L54C19

or:

https://github.com/mcneel/rhino3dm/blob/2be29689d99a9b8c0b511e3646cbe38a0bad6a81/src/rhino3dm/__init__.pyi#L309C1-L329C50

In case just let me know which files I have to update and I will follow up with a dedicated PR.

Thanks a lot!

@fraguada
Copy link
Member

fraguada commented Jan 9, 2025

The python stubs getting updated is one of the projects I need to look at soon. We have a semi automated process, but like the js typings, I need to do some manual additions and cleanup.

The docs/python/api are generated automatically from the src/docgen project. I run this process when I do a release. It also generates stubs. The issue is that docgen has its limitations.

I think it would be fine to update src/rhino3dm/init.pyi and keep that manually maintained. As things are added we can compare the autogenerated stubs and merge into the maintained version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants