Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove collector update script and schema #20912

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Conversation

queengooborg
Copy link
Collaborator

This PR removes schema docs and scripts related to the mdn-bcd-collector project. The decision was to keep these files inside of the collector, rather than in BCD.

@github-actions github-actions bot added schema Isses or pull requests regarding the JSON schema files used in this project. docs Issues or pull requests regarding the documentation of this project. scripts Issues or pull requests regarding the scripts in scripts/. labels Oct 7, 2023
@queengooborg queengooborg merged commit 0121875 into main Oct 7, 2023
6 checks passed
@queengooborg queengooborg deleted the remove-collector-data branch October 7, 2023 05:28
@Elchi3
Copy link
Member

Elchi3 commented Oct 9, 2023

@queengooborg This PR was not reviewed. That's not okay.

I think not all relevant files have been removed here. The original PR (#19971) added a UA parser and additional dependencies.

@queengooborg
Copy link
Collaborator Author

I'll admit that I hadn't actually meant to merge this when I did, but since this is the plan we had discussed in the BCD call, I didn't think reverting it and submitting a replacement PR was reasonable.

I'll submit a PR to follow up and remove the remaining bits.

teoli2003 pushed a commit to teoli2003/browser-compat-data that referenced this pull request Oct 13, 2023
Elchi3 pushed a commit to Elchi3/browser-compat-data that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues or pull requests regarding the documentation of this project. schema Isses or pull requests regarding the JSON schema files used in this project. scripts Issues or pull requests regarding the scripts in scripts/.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants