Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(husky): add post pull hook to suggest running 'npm install' #22308

Merged
merged 4 commits into from
Mar 3, 2024
Merged

feat(husky): add post pull hook to suggest running 'npm install' #22308

merged 4 commits into from
Mar 3, 2024

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Feb 27, 2024 •
edited
Loading

@github-actions github-actions bot added infra Infrastructure issues (npm, GitHub Actions, releases) of this project dependencies Pull requests that update a dependency package or file. scripts Issues or pull requests regarding the scripts in scripts/. labels Feb 27, 2024
@OnkarRuikar OnkarRuikar force-pushed the ci_install_suggestion branch from b4998f5 to 44489e8 Compare February 27, 2024 09:50
@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Mar 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Mar 2, 2024
queengooborg
queengooborg approved these changes Mar 3, 2024
View reviewed changes
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this, LGTM!

@queengooborg queengooborg merged commit 2250802 into mdn:main Mar 3, 2024
6 checks passed
@OnkarRuikar OnkarRuikar deleted the ci_install_suggestion branch March 4, 2024 01:35
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Mar 5, 2024
@ddbeck
Unbreak installing from Git
dc18cd7 
`save-git-history.ts` (introduced in
mdn#22308) breaks installing BCD from Git (in a fit of irony, there won't be a `.git` if you use `npm install github:mdn/browser-compat-data`).

While I'm here, I've stopped the script from running if you, like me,
have `HUSKY=0` set.
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Mar 5, 2024
@ddbeck
Unbreak installing from Git
0ba8119 
`save-git-history.ts` (introduced in
mdn#22308) breaks installing BCD from Git (in a fit of irony, there won't be a `.git` if you use `npm install github:mdn/browser-compat-data`).

While I'm here, I've stopped the script from running if you, like me,
have `HUSKY=0` set.
@ddbeck ddbeck mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency package or file. infra Infrastructure issues (npm, GitHub Actions, releases) of this project scripts Issues or pull requests regarding the scripts in scripts/.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OnkarRuikar @queengooborg