Update Safari versions for TypedArray #23319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:js
These 11 entries are changed by collector results: openwebdocs/mdn-bcd-results#1098 openwebdocs/mdn-bcd-results#1099 The collector shows no support in Safari 9.1 and support in 10.1, so source archeology was needed to decide between Safari 10 and 10.1. The 10 methods `copyWithin()`, `entries()`, `every()`, `fill()`, `filter()`, `find()`, `findIndex()`, `indexOf()`, `join()`, and `map()` were added in WebKit 602.1.6: WebKit/WebKit@881b0bf https://github.com/WebKit/WebKit/blob/881b0bfc93b6e6394676fbf712681792d72b2afa/Source/WebCore/Configurations/Version.xcconfig (See `JSTypedArrayViewPrototype::finishCreation`.) The static `of()` was added in WebKit 602.1.7: WebKit/WebKit@6fa0cb5 https://github.com/WebKit/WebKit/blob/6fa0cb524bcdd5091d1525846064f85782b9f0dd/Source/WebCore/Configurations/Version.xcconfig Both of those WebKit versions map to Safari 10. The Safari 9.1 data came from mdn#6480. That points to first commit above, but must have mapped it to a Safari version incorrectly. Note that some of the data was already set to Safari 10 going back to mdn#351.
foolip
force-pushed
the
safari-typedarray
branch
from
d3a26e1 to
2e61e48
Compare
foolip
added a commit
to foolip/web-features
that referenced
this pull request
Jun 10, 2024
The correct version for typed arrays was carefully researched here: mdn/browser-compat-data#23319 This changes the Baseline low date by 1 year.
foolip
added a commit
to foolip/web-features
that referenced
this pull request
Jun 10, 2024
Safari 9.1 vs 10 was carefully researched here: mdn/browser-compat-data#23319 Where BCD is still wrong, we have to keep the data manually maintained until the next BCD release. After that it can be generated as .yml.dist. This changes the Baseline low date by 1 year.
Elchi3
approved these changes
Jun 10, 2024
Yep, I understand. I only had to look into it because it was the keystone release, and it changes what the Baseline year is. |
foolip
added a commit
to web-platform-dx/web-features
that referenced
this pull request
Jun 10, 2024
Safari 9.1 vs 10 was carefully researched here: mdn/browser-compat-data#23319 Where BCD is still wrong, we have to keep the data manually maintained until the next BCD release. After that it can be generated as .yml.dist. This changes the Baseline low date by 1 year.
|
Here's a hint how much work it would be to go further into the past using the @openwebdocs collector project and the diff it spits out: openwebdocs/project#167 (comment). So, not impossible to work further into the past but definitely work. |
|
Thanks @Elchi3! My hunch is that it'll only be a sliver of this data that will end up affecting a Baseline low date between 2016 and 2020, but right now there's no way to know if a Baseline low date would be changed by a collector update. Just knowing when that's the case, then the proposed collector changes that could change a Baseline date could be reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These 11 entries are changed by collector results:
openwebdocs/mdn-bcd-results#1098
openwebdocs/mdn-bcd-results#1099
The collector shows no support in Safari 9.1 and support in 10.1, so
source archeology was needed to decide between Safari 10 and 10.1.
The 10 methods
copyWithin(),entries(),every(),fill(),filter(),find(),findIndex(),indexOf(),join(), andmap()were added in WebKit 602.1.6:
WebKit/WebKit@881b0bf
https://github.com/WebKit/WebKit/blob/881b0bfc93b6e6394676fbf712681792d72b2afa/Source/WebCore/Configurations/Version.xcconfig
(See
JSTypedArrayViewPrototype::finishCreation.)The static
of()was added in WebKit 602.1.7:WebKit/WebKit@6fa0cb5
https://github.com/WebKit/WebKit/blob/6fa0cb524bcdd5091d1525846064f85782b9f0dd/Source/WebCore/Configurations/Version.xcconfig
Both of those WebKit versions map to Safari 10.
The Safari 9.1 data came from #6480.
That points to first commit above, but must have mapped it to a Safari
version incorrectly.
Note that some of the data was already set to Safari 10 going back to
#351.