Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(css): Fx116 - syntax updates for offset-path and ray() #28348
docs(css): Fx116 - syntax updates for offset-path and ray() #28348
Changes from 9 commits
17972a3
a39899a
ce2c4c9
efb2ec5
d2b8413
53d9f32
29a0d3a
d261b5d
bb13346
78af25b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not wanting to hold anything up with this question, but...
we use
<box>
on 17, 18, and 19. It is introduced in line 16 as a comment.we use
<layout-box>
on 21, which is the name on 18, with the comment of 18 introducing<shape-box>
, but we're not using<shape-box>
thinking this may be a way of updating this:
and then adding the "also referred to as " under layout box in the values section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an excellent observation!
<shape-box>
in the syntax is because it occurs in the shape-outside property.It is defined in the Shapes module spec as:
<shape-box> = <box> | margin-box
(https://drafts.csswg.org/css-shapes/#typedef-shape-box)(but the Box module spec defines the data type as
<layout-box>
, so keeping that as is here...)<geometry-box>
,<shape-box>
, and<box>
. Another reason why I wanted to define what's<shape-box>
and<box>
.<box>
in a few other "Formal syntax" sections.<box-edge>
page in the future and update their value descriptions as well.How about for
<geometry-box>
, we use<shape-box>
instead of<layout-box>
? (Because<shape-box>
is more commonly used, but there are no occurrences of<layout-box>
in content..yet!)Updated text:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still looking for a property that uses this... no luck. Do you have know how we can look at a web ref dump?
I am thinking that since in SVG,
border-box
is treated asstroke-box
andpadding-box
is treated asfill-box
, is paint-box just a synonym for visual box?Maybe @fantasai can give us insight?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea but it would be good to learn how to.
I guess we keep this description as is for now and update when we have more info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't seem like the right definition. We're talking about all the values that make up coord-box, not actual coordinate box. Maybe:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, in the descriptions of the other data types, we define them as the space, area, or box.
Perhaps I should update all the data type descriptions to state the possible values?
And also update the description of keywords such as
content-box
andborder-box
to specify the area they enclose instead of referring to the edge? The description of these keywords in the shape-outside property page follows this style.