Fix typos and pseudo-typos 10 #36251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
| @@ -58,10 +58,10 @@ const bindGroup = device.createBindGroup({ | |||
| }, | |||
| }, | |||
| ], | |||
| label: "mybindgroup", | |||
| label: "my-bind-group", | |||
There was a problem hiding this comment.
FWIW, and probably too late, I much prefer underscores as a word separator.
There was a problem hiding this comment.
I have no objection to that so at least we can use underscores for WebGPU docs. Frankly, I would have used spaces since these labels are arbitrary anyway.
There was a problem hiding this comment.
So yes, for labels, spaces make more sense. For code I prefer camelcase or _
There was a problem hiding this comment.
But thanks for the change!
hamishwillee
approved these changes
Oct 27, 2024
|
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am fixing a lot of nits in content. The goal is to make our custom dictionaries as small as possible by eliminating things that could be better recognized as words. This not only helps with automation but helps with human readers too, especially those who may be slow to recognize words.
cSpell:ignoreto prevent it being ignored in other files.