Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update filter-function-list to filter-value-list #37633

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Update filter-function-list to filter-value-list #37633

merged 2 commits into from
Jan 17, 2025

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Jan 13, 2025 •
edited
Loading

Description

the spec has renamed this syntax

https://drafts.fxtf.org/filter-effects/#propdef-filter
https://drafts.fxtf.org/filter-effects-2/#propdef-backdrop-filter

Motivation

Additional details

Related issues and pull requests

mdn/data#897 for data update

@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/xs [PR only] 0-5 LoC changed labels Jan 13, 2025
@skyclouds2001 skyclouds2001 mentioned this pull request Jan 13, 2025
Open
@skyclouds2001 skyclouds2001 marked this pull request as ready for review January 13, 2025 17:04
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner January 13, 2025 17:04
@skyclouds2001 skyclouds2001 requested review from estelle and removed request for a team January 13, 2025 17:04
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 13, 2025 •
edited
Loading

Preview URLs

Flaws (48)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/backdrop-filter
Title: backdrop-filter
Flaw count: 48

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/CSS_basics
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/What_is_CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/Getting_started
    • and 43 more flaws omitted

(comment last updated: 2025-01-15 16:40:04)

@estelle
Copy link
Member

estelle commented Jan 15, 2025

Should we change it on SVG/Attribute/filter too?

@skyclouds2001 skyclouds2001 requested a review from a team as a code owner January 15, 2025 16:38
@skyclouds2001 skyclouds2001 requested review from hamishwillee and removed request for a team January 15, 2025 16:38
@github-actions github-actions bot added the Content:SVG SVG docs label Jan 15, 2025
@skyclouds2001
Copy link
Contributor Author

Should we change it on SVG/Attribute/filter too?

sure!

estelle
estelle approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit 4030a33 into mdn:main Jan 17, 2025
9 checks passed
@skyclouds2001 skyclouds2001 deleted the filter branch January 17, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

@hamishwillee hamishwillee Awaiting requested review from hamishwillee hamishwillee is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @estelle