Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(http): replace images w/ shared-assets #37643

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(http): replace images w/ shared-assets #37643

wants to merge 2 commits into from

Conversation

Jxck
Copy link
Contributor

@Jxck Jxck commented Jan 14, 2025 •
edited by bsmth
Loading

Description

replace png images in caching section w/ shared-assets svg

Related issues and pull requests

Depends on:

@Jxck Jxck requested a review from a team as a code owner January 14, 2025 09:48
@Jxck Jxck requested review from hamishwillee and removed request for a team January 14, 2025 09:48
@github-actions github-actions bot added Content:HTTP HTTP docs size/xs [PR only] 0-5 LoC changed labels Jan 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

Preview URLs

(comment last updated: 2025-01-15 10:00:49)

@bsmth bsmth self-requested a review January 14, 2025 09:51
@bsmth bsmth changed the title replace images w/ shared-assets chore(http): replace images w/ shared-assets Jan 15, 2025
bsmth
bsmth reviewed Jan 15, 2025
View reviewed changes
files/en-us/web/http/caching/index.md
@@ -72,7 +72,7 @@ That means if a managed cache intentionally ignores a `no-store` directive, ther

Note that some CDNs provide their own headers that are effective only for that CDN (for example, `Surrogate-Control`). Currently, work is underway to define a [`CDN-Cache-Control`](https://httpwg.org/specs/rfc9213.html) header to standardize those.

![Type of Cache](type-of-cache.png)
![Type of Cache](https://mdn.github.io/shared-assets/images/diagrams/http/cache/type-of-cache.svg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![Type of Cache](https://mdn.github.io/shared-assets/images/diagrams/http/cache/type-of-cache.svg)
![Types of caches, including a private cache in the browser, a shared (proxy) cache, a reverse proxy cache, and a shared (managed) cache in a CDN, leading to the origin server's cache](https://mdn.github.io/shared-assets/images/diagrams/http/cache/type-of-cache.svg)

bsmth
bsmth reviewed Jan 15, 2025
View reviewed changes
files/en-us/web/http/caching/index.md
@@ -481,7 +481,7 @@ Request collapse occurs when requests are arriving at the same time, so even if

If the response is personalized to a particular user and you do not want it to be shared in collapse, you should add the `private` directive:

![Request Collapse](request-collapse.png)
![Request Collapse](https://mdn.github.io/shared-assets/images/diagrams/http/cache/request-collapse.svg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![Request Collapse](https://mdn.github.io/shared-assets/images/diagrams/http/cache/request-collapse.svg)
![Request collapse shown as multiple clients sending GET requests and a cache consolidating them into one GET to the origin. The origin server responds with a 200 OK that the cache shares back to all clients.](https://mdn.github.io/shared-assets/images/diagrams/http/cache/request-collapse.svg)

bsmth
bsmth approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better, thanks. Two comments about alt text to look at, but +1 and fine to merge when you're ready

@bsmth bsmth removed the request for review from hamishwillee January 15, 2025 10:15
@estelle
Copy link
Member

estelle commented Jan 15, 2025

Hi @Jxck. Thanks for the PR. You may find https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/alt helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
Content:HTTP HTTP docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jxck @estelle @bsmth