Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More information about formatToParts pages #37658

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

SurajKharkwal
Copy link
Contributor

Description

This pull request corrects a JavaScript mistake in the Named Years and Mixed Calendars section of MDN Web Docs. Specifically, it updates the code examples to properly handle formatting options for the Chinese calendar using Intl.DateTimeFormat.

Motivation

The current example contains an error that may lead to confusion or incorrect usage when developers work with named years and mixed calendar formats. Correcting this example ensures clarity and accuracy for MDN readers, helping them better understand the behavior of Intl.DateTimeFormat.

Related issues and pull requests

Fixes : #37609

@SurajKharkwal SurajKharkwal requested a review from a team as a code owner January 15, 2025 16:38
@SurajKharkwal SurajKharkwal requested review from Josh-Cena and removed request for a team January 15, 2025 16:38
@github-actions github-actions bot added Content:JS JavaScript docs size/s [PR only] 6-50 LoC changed labels Jan 15, 2025
@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Jan 16, 2025
@Josh-Cena Josh-Cena changed the title Fix issue in Named Year: Fix Issue #37609 More information about formatToParts pages Jan 16, 2025
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at this page and there are many places that could be revised. I went ahead and then decided to propagate these fixes to other formatToParts pages. This makes this PR much bigger than needed but alas, I think this is more ideal. Thank you!

@Josh-Cena Josh-Cena merged commit 1574e47 into mdn:main Jan 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing text and the same code output
2 participants