Skip to content

chore(css): merge CSS Units group into CSS Values and Units #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 4, 2025
Merged

chore(css): merge CSS Units group into CSS Values and Units #879

merged 5 commits into from
Apr 4, 2025

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Jan 4, 2025 •
edited
Loading

Description

merge CSS Units group and other unit-related groups into, this follows the structure of the specification and mdn web docs

https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Values_and_Units
https://drafts.csswg.org/css-values/
https://drafts.csswg.org/css-values-5/

Motivation

Additional details

Related issues and pull requests

@skyclouds2001 skyclouds2001 marked this pull request as ready for review January 4, 2025 14:55
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner January 4, 2025 14:55
@skyclouds2001 skyclouds2001 requested review from pepelsbey and removed request for a team January 4, 2025 14:55
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Feb 14, 2025
skyclouds2001
skyclouds2001 commented Feb 21, 2025
View reviewed changes
pepelsbey
pepelsbey reviewed Feb 24, 2025
View reviewed changes
Copy link
Member

@pepelsbey pepelsbey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the removal of the .github/workflows/codeql.yml is not mentioned/justified in the description, and there are many other changes, too. It seems like the other feature branch (next) got merged here and widened the scope of the PR.

@pepelsbey pepelsbey removed the idle Issues and pull requests with no activity for three months. label Feb 24, 2025
@skyclouds2001
Copy link
Contributor Author

I noticed the removal of the .github/workflows/codeql.yml is not mentioned/justified in the description, and there are many other changes, too. It seems like the other feature branch (next) got merged here and widened the scope of the PR.

guessing that happens due to unexpected merge/rebase

@skyclouds2001 skyclouds2001 requested a review from pepelsbey March 19, 2025 17:22
skyclouds2001
skyclouds2001 commented Mar 19, 2025
View reviewed changes
pepelsbey
pepelsbey approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

@pepelsbey pepelsbey merged commit c6f42b0 into mdn:main Apr 4, 2025
1 check passed
@github-actions github-actions bot mentioned this pull request Apr 4, 2025
Merged
@skyclouds2001 skyclouds2001 deleted the merge-unit-group branch April 4, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepelsbey pepelsbey pepelsbey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @pepelsbey