[alpha-unito#54] explicit one-argument GlobalPointer constructor

mdrocco · Feb 9, 2019 · 65d5852 · 65d5852
1 parent 48f0b68
commit 65d5852
Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/include/gam/Context.hpp b/include/gam/Context.hpp
@@ -579,7 +579,7 @@ class Context {
         /*
          * destroy and un-bind committed memory
          */
-        unmap(a);
+        unmap(p);
     } else
       forward_dec(p);
   }
@@ -734,7 +734,7 @@ class Context {
           case daemon_pointer::RC_DEC:
             LOGLN("DMN recv -1 %llu from %lu", a, p.from);
             assert(ctx.view.author(a) == ctx.rank());
-            if (ctx.mc.rc_dec(a) == 0) ctx.unmap(a);
+            if (ctx.mc.rc_dec(a) == 0) ctx.unmap(p.p);
             break;
           case daemon_pointer::RC_GET: {
             LOGLN("DMN recv RC_GET %llu from %lu", a, p.from);
@@ -747,7 +747,7 @@ class Context {
             LOGLN("DMN recv PVT -1 %llu from %lu", a, p.from);
             assert(ctx.view.author(a) == ctx.rank_);
             assert(ctx.view.committed(a) != nullptr);
-            ctx.unmap(a);
+            ctx.unmap(p.p);
             break;
           case daemon_pointer::RLOAD:
             LOGLN("DMN recv RLOAD %llu from %lu", a, p.from);

diff --git a/include/gam/GlobalPointer.hpp b/include/gam/GlobalPointer.hpp
@@ -62,7 +62,7 @@ class GlobalPointer {
 
   GlobalPointer() {}
 
-  GlobalPointer(uint64_t descriptor) : descriptor_(descriptor) {}
+  explicit GlobalPointer(uint64_t descriptor) : descriptor_(descriptor) {}
 
   GlobalPointer(executor_id home, uint64_t lsb)
       : GlobalPointer(lsb | ((uint64_t)home << 32)) {