[Scripts] Deploy implementations direct #185
Open
+274
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a client request to deploy a launchpad contract with a vanity address, but we can't do this with our existing factory deployment flow:
The salt for the vanity address needs to be pre-computed with
forge create2
. However, when this salt is passed tocreateContractDeterministic
it's re-hashed withmsg.sender
andblock.chainId
. Meaning, the salt will not be the same and the vanity address with not be achieved:magicdrop/contracts/factory/MagicDropCloneFactory.sol
Line 122 in cd314bc
These scripts directly deploy ERC721CM (non-initializable variant) directly using the pre-computed salt to achieve the vanity address via CREATE2.