Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Asynchronously commit the full unsafePayload to other nodes and conductor #15

Open
wants to merge 4 commits into
base: testnet
Choose a base branch
from
Open

feat: Asynchronously commit the full unsafePayload to other nodes and conductor #15

wants to merge 4 commits into from

Conversation

SilasZhr
Copy link
Collaborator

Changes:

  • Add a new event executor conductor-helper to asynchronously commit the full unsafePayload to other nodes and conductor
  • Add a new Event CommitPayloadEvent to trigger helper commit the full unsafePayload in the original build_seal process.

claymega
claymega reviewed Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@claymega claymega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR adds conductorHelper handler, not adds event executor.

This code seems to be fine, but the functionality cannot be verified because the op-conductor script has not been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claymega claymega claymega left review comments

@yangl1996 yangl1996 Awaiting requested review from yangl1996

@yilongli yilongli Awaiting requested review from yilongli

@Troublor Troublor Awaiting requested review from Troublor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SilasZhr @claymega