Attempt to fix pydantic-model-prototype
tests
#493
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is my attempt to fix the tests on the
pydantic-model-protoype
branch.@ieivanov demonstrated his local failure to me, and pointed out that napari seemed to hang. Although I'm not able to reproduce @ieivanov's hang locally myself, his demo was a key lead---when I skip
test_dock_widget
(seed41f4c5
), the tests pass.This is a "cheating" fix, though, because this is a useful test. @amitabhverma I now suspect that that your first failing commit
f91b4e9
introduced a regression that is interfering with napari's shutdown/cleanup. I tried a couple easy ideas (see notes below), but I wasn't able to find the core issue. Is it possible that the jobs manager isn't cleaning up correctly? I have not read through every line off91b4e9
yet.Notes:
d41f4c5
passes --- this is a "cheating" fix, which skips the napari test. This points me towards hanging processes that are interfering with the napari process.358d514
hangs --- this rules out the cli debugging path as being the issue.e0e2715
hangs --- this rules out the tab_recon debugging path as being the issue.9b71e19
hangs --- confirming that the HEAD ofpydantic-model-prototype
hangs