Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix pydantic-model-prototype tests #493

Closed

Conversation

talonchandler
Copy link
Collaborator

@talonchandler talonchandler commented Jan 7, 2025

This PR is my attempt to fix the tests on the pydantic-model-protoype branch.

@ieivanov demonstrated his local failure to me, and pointed out that napari seemed to hang. Although I'm not able to reproduce @ieivanov's hang locally myself, his demo was a key lead---when I skip test_dock_widget (see d41f4c5), the tests pass.

This is a "cheating" fix, though, because this is a useful test. @amitabhverma I now suspect that that your first failing commit f91b4e9 introduced a regression that is interfering with napari's shutdown/cleanup. I tried a couple easy ideas (see notes below), but I wasn't able to find the core issue. Is it possible that the jobs manager isn't cleaning up correctly? I have not read through every line of f91b4e9 yet.

Notes:
d41f4c5 passes --- this is a "cheating" fix, which skips the napari test. This points me towards hanging processes that are interfering with the napari process.
358d514 hangs --- this rules out the cli debugging path as being the issue.
e0e2715 hangs --- this rules out the tab_recon debugging path as being the issue.
9b71e19 hangs --- confirming that the HEAD of pydantic-model-prototype hangs

@talonchandler talonchandler changed the title draft: trying to fix tests Attempt to fix pydantic-model-prototype tests Jan 7, 2025
@amitabhverma
Copy link
Collaborator

Thanks @talonchandler
This was very useful in finding the issue which seem to arise from the server socket blocking napari closing when running headless for tests. I believe the close event is not triggered in this case which is where I do the cleanup and stopping of threads/socket/processes currently running.

The changes have been incorporated #487

@talonchandler
Copy link
Collaborator Author

Great! Closing.

@talonchandler talonchandler deleted the fix-pydantic-model-tests branch January 8, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants