Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set gthesheep TikTok tap variant to default #698

Merged
merged 3 commits into from
Aug 5, 2022
Merged

Set gthesheep TikTok tap variant to default #698

merged 3 commits into from
Aug 5, 2022

Conversation

GtheSheep
Copy link
Contributor

Checklist

  • Add/update the file in the appropriate folder (/taps or /targets). The name of the file should match the name of the tap. If there is already one, add a descriptor to the name such as -search.
  • Add/update the PNG logo image in /assets/logos/<taps or targets>. The image name must match the YAML file name.
  • Tag @tayloramurphy or @pnadolny13 to flag it for review. Or post to the #hub channel on Meltano slack.

Reviewer Checklist

@pnadolny13 @tayloramurphy - the difference between the 2 taps appears to be the inclusion of reservation ads based on the schema, I've added a task to my repo to add these as I'll be working on the tap this week anyway to add audience stats

@netlify
Copy link

netlify bot commented Aug 4, 2022

Deploy Preview for meltano-hub ready!

Name Link
🔨 Latest commit 6c74977
🔍 Latest deploy log https://app.netlify.com/sites/meltano-hub/deploys/62ec1ed9f7bd74000969d205
😎 Deploy Preview https://deploy-preview-698--meltano-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@GtheSheep
Copy link
Contributor Author

I take it that's not how to set defaults? 😂

@pnadolny13
Copy link
Contributor

@GtheSheep thanks for this! Yeah we used to set defaults inside the plugin file but now the way to do it is to set it in the default_variants.yml.

@pnadolny13 pnadolny13 self-requested a review August 5, 2022 13:42
Copy link
Contributor

@pnadolny13 pnadolny13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@pnadolny13 pnadolny13 merged commit 85a72d1 into meltano:main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants