-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Reorganize docs and add deprecation timeline #1353
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1353 +/- ##
=======================================
Coverage 85.19% 85.19%
=======================================
Files 54 54
Lines 4722 4722
Branches 803 803
=======================================
Hits 4023 4023
Misses 507 507
Partials 192 192
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
be088f8
to
179a252
Compare
@edgarrmondragon is it possible to specify redirects? I know we've linked a bunch of folks directly to the current batch and inline stream maps links on the sidebar. |
Yeah, let me try adding the redirects. |
1952931
to
9458360
Compare
@edgarrmondragon Awesome! I think it'd be worth getting Sven to review this PR as well. |
Merged in the contributions from @kgpayne in #1381. Here are my copy-pasted feedback items from that PR. The only ones I feel really strongly about are the ones that will change the hosted URL, since those will be another breaking change if held for later. Just focusing on nav structure, for which we want to reduce later breaking changes:
The other nesting looks great! I see Some other small reorg notes, none of which are breaking so if we want to hold for now, we totally can:
Some titles have redundant references which we can clean up. None of these naming issues need to be part of this PR, per se, but if it's easy enough to clean them up, then great. 👍
@edgarrmondragon - What do you think of at least including the revisions above that affect the URLs, and optionally some of the other more cosmetic items? cc @sbalnojan as fyi |
cc @sbalnojan |
@aaronsteers Yeah, that makes sense. I'll start with the URL changes. |
738a703
to
31ca7f6
Compare
31ca7f6
to
688c9e7
Compare
@edgarrmondragon just checking if this is 'ready for review'? before I check it out in more detail 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as I think this is a good iteration. We've got redirects and the overall content is better structured. @sbalnojan it would be good if you can do a review on this please!
@kgpayne This is ready now 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @edgarrmondragon, for incorporating the latest changes. Looks great!
Extracted from #1294
📚 Documentation preview 📚: https://meltano-sdk--1353.org.readthedocs.build/en/1353/