-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Check if replication key is timestamp before using start_date as default #1734
base: main
Are you sure you want to change the base?
fix: Check if replication key is timestamp before using start_date as default #1734
Conversation
@kgpayne thanks for pushing the target test fixes. I have noticed that I need to add in one of the fixes for #1676 locally before the sqlite tests run. The failures after the type error is corrected are in Should the SDK accommodate for differing start_date input formats #855 I am not sure how to move forward with the Unix timestamp failures. The tests are there to keep SDK taps from breaking configurations that have been seen out in production. I am starting to wonder if I should resolve this in my tap-mssql and close this PR since it may break taps or pipelines that are in production. wdyt? |
…-fix-do-not-use-start-date-with-non-date-columns
@BuzzCutNorman I agree that, as a breaking change, we should keep this back until v1.0. Added it to the v1.0 Milestone 👍 |
@kgpayne Thanks🙏 for the direction. |
CodSpeed Performance ReportMerging #1734 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1734 +/- ##
==========================================
- Coverage 89.47% 89.43% -0.05%
==========================================
Files 58 58
Lines 4799 4799
Branches 937 937
==========================================
- Hits 4294 4292 -2
- Misses 352 353 +1
- Partials 153 154 +1 ☔ View full report in Codecov by Sentry. |
This is an attempt to implement the proposed fix outlined in #1677
Closes #1677
📚 Documentation preview 📚: https://meltano-sdk--1734.org.readthedocs.build/en/1734/