refactor: Implement a SingerWriter class in singer_sdk.io_base and use it to emit Singer messages
#2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuzzCutNorman
requested review from
edgarrmondragon and
kgpayne
as code owners
CodSpeed Performance ReportMerging #2058 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2058 +/- ##
==========================================
+ Coverage 87.45% 87.46% +0.01%
==========================================
Files 58 58
Lines 4861 4867 +6
Branches 994 993 -1
==========================================
+ Hits 4251 4257 +6
Misses 429 429
Partials 181 181 ☔ View full report in Codecov by Sentry. |
edgarrmondragon
requested changes
Nov 21, 2023
edgarrmondragon
changed the title
SingerWriter class in singer_sdk.io_base and use it to emit Singer messages
edgarrmondragon
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a
SingerWriterclass insinger_sdk.io_basewhich the write_message(), and format_message functions from singer_sdk._singerlib.messages are placed into. After doinng this all the stdin and stdout methods, json encoders, and json decoder would be in one file. SingerWriter was added as an inherited class of Tap just like SingerReader is an inherited class of Target.📚 Documentation preview 📚: https://meltano-sdk--2058.org.readthedocs.build/en/2058/