Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(target): Turn drain_one into a async method #2289

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Merge branch 'main' into feat-target-asyncio-drain-one

e89c328
Select commit
Loading
Failed to load commit list.
Draft

feat(target): Turn drain_one into a async method #2289

Merge branch 'main' into feat-target-asyncio-drain-one
e89c328
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 4, 2024 in 1s

88.65% (-0.11%) compared to 26021c1

View this Pull Request on Codecov

88.65% (-0.11%) compared to 26021c1

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.65%. Comparing base (26021c1) to head (e89c328).
Report is 40 commits behind head on main.

Files Patch % Lines
singer_sdk/target_base.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2289      +/-   ##
==========================================
- Coverage   88.76%   88.65%   -0.11%     
==========================================
  Files          54       54              
  Lines        4769     4770       +1     
  Branches      928      928              
==========================================
- Hits         4233     4229       -4     
- Misses        374      377       +3     
- Partials      162      164       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.