Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: In SQL targets, users can now disable column type alterations with the allow_column_alter built-in setting #2504

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions samples/sample_duckdb/connector.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@


class DuckDBConnector(SQLConnector):
allow_column_alter = True

@staticmethod
def get_column_alter_ddl(
table_name: str,
Expand Down
12 changes: 9 additions & 3 deletions singer_sdk/connectors/sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@
from singer_sdk._singerlib import CatalogEntry, MetadataMapping, Schema
from singer_sdk.exceptions import ConfigValidationError
from singer_sdk.helpers._util import dump_json, load_json
from singer_sdk.helpers.capabilities import TargetLoadMethods
from singer_sdk.helpers.capabilities import (
TARGET_ALLOW_COLUMN_ALTER_CONFIG,
TargetLoadMethods,
)

if sys.version_info < (3, 13):
from typing_extensions import deprecated
Expand Down Expand Up @@ -473,7 +476,10 @@

allow_column_add: bool = True # Whether ADD COLUMN is supported.
allow_column_rename: bool = True # Whether RENAME COLUMN is supported.
allow_column_alter: bool = False # Whether altering column types is supported.

#: Whether altering column types is supported.
allow_column_alter = TARGET_ALLOW_COLUMN_ALTER_CONFIG.attribute(default=False)

Check warning on line 481 in singer_sdk/connectors/sql.py

View workflow job for this annotation

GitHub Actions / Check API Changes

SQLConnector.allow_column_alter

Attribute value was changed: `False` -> `TARGET_ALLOW_COLUMN_ALTER_CONFIG.attribute(default=False)`

allow_merge_upsert: bool = False # Whether MERGE UPSERT is supported.
allow_overwrite: bool = False # Whether overwrite load method is supported.
allow_temp_tables: bool = True # Whether temp tables are supported.
Expand Down Expand Up @@ -1619,7 +1625,7 @@
return

# Not the same type, generic type or compatible types
# calling merge_sql_types for assistnace
# calling merge_sql_types for assistance
compatible_sql_type = self.merge_sql_types([current_type, sql_type])

if str(compatible_sql_type) == str(current_type):
Expand Down
41 changes: 41 additions & 0 deletions singer_sdk/helpers/_config_property.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
from __future__ import annotations

import typing as t

T = t.TypeVar("T")


class ConfigProperty(t.Generic[T]):
"""A descriptor that gets a value from a named key of the config attribute."""

def __init__(self, custom_key: str | None = None, *, default: T | None = None):
"""Initialize the descriptor.

Args:
custom_key: The key to get from the config attribute instead of the
attribute name.
default: The default value if the key is not found.
"""
self.key = custom_key
self.default = default

def __set_name__(self, owner, name: str) -> None: # noqa: ANN001
"""Set the name of the attribute.

Args:
owner: The class of the object.
name: The name of the attribute.
"""
self.key = self.key or name

def __get__(self, instance, owner) -> T | None: # noqa: ANN001
"""Get the value from the instance's config attribute.

Args:
instance: The instance of the object.
owner: The class of the object.

Returns:
The value from the config attribute.
"""
return instance.config.get(self.key, self.default) # type: ignore[no-any-return]
52 changes: 52 additions & 0 deletions singer_sdk/helpers/capabilities.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from enum import Enum, EnumMeta
from warnings import warn

from singer_sdk.helpers._config_property import ConfigProperty
from singer_sdk.typing import (
ArrayType,
BooleanType,
Expand All @@ -19,6 +20,47 @@
)

_EnumMemberT = t.TypeVar("_EnumMemberT")
T = t.TypeVar("T")


class Builtin:
"""Use this class to define built-in setting(s) for a plugin."""

def __init__(
self,
schema: dict[str, t.Any],
*,
capability: CapabilitiesEnum | None = None,
**kwargs: t.Any,
):
"""Initialize the descriptor.

Args:
schema: The JSON schema for the setting.
capability: The capability that the setting is associated with.
kwargs: Additional keyword arguments.
"""
self.schema = schema
self.capability = capability
self.kwargs = kwargs

def attribute( # noqa: PLR6301
self,
custom_key: str | None = None,
*,
default: T | None = None,
) -> ConfigProperty[T]:
"""Generate a class attribute for the setting.

Args:
custom_key: Custom key to use in the config.
default: Default value for the setting.

Returns:
Class attribute for the setting.
"""
return ConfigProperty(custom_key=custom_key, default=default)


# Default JSON Schema to support config for built-in capabilities:

Expand Down Expand Up @@ -188,6 +230,16 @@
),
).to_dict()

TARGET_ALLOW_COLUMN_ALTER_CONFIG = Builtin(
schema=PropertiesList(
Property(
"allow_column_alter",
BooleanType,
description="Allow altering columns in the target database.",
),
).to_dict(),
)


class TargetLoadMethods(str, Enum):
"""Target-specific capabilities."""
Expand Down
3 changes: 3 additions & 0 deletions singer_sdk/target_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
ACTIVATE_VERSION_CONFIG,
ADD_RECORD_METADATA_CONFIG,
BATCH_CONFIG,
TARGET_ALLOW_COLUMN_ALTER_CONFIG,
TARGET_BATCH_SIZE_ROWS_CONFIG,
TARGET_HARD_DELETE_CONFIG,
TARGET_LOAD_METHOD_CONFIG,
Expand Down Expand Up @@ -708,6 +709,8 @@ def _merge_missing(source_jsonschema: dict, target_jsonschema: dict) -> None:
if k not in target_jsonschema["properties"]:
target_jsonschema["properties"][k] = v

_merge_missing(TARGET_ALLOW_COLUMN_ALTER_CONFIG.schema, config_jsonschema)

capabilities = cls.capabilities

if TargetCapabilities.TARGET_SCHEMA in capabilities:
Expand Down
Empty file.
33 changes: 33 additions & 0 deletions tests/core/helpers/test_config_property.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
"""Test the BuiltinSetting descriptor."""

from __future__ import annotations

from singer_sdk.helpers._config_property import ConfigProperty


def test_builtin_setting_descriptor():
class ObjWithConfig:
example = ConfigProperty(default=1)

def __init__(self):
self.config = {"example": 1}

obj = ObjWithConfig()
assert obj.example == 1

obj.config["example"] = 2
assert obj.example == 2


def test_builtin_setting_descriptor_custom_key():
class ObjWithConfig:
my_attr = ConfigProperty("example", default=1)

def __init__(self):
self.config = {"example": 1}

obj = ObjWithConfig()
assert obj.my_attr == 1

obj.config["example"] = 2
assert obj.my_attr == 2
1 change: 1 addition & 0 deletions tests/core/targets/test_target_sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ class MyTarget(SQLTargetMock, capabilities=capabilities):
about = MyTarget._get_about_info()
default_settings = {
"add_record_metadata",
"allow_column_alter",
"load_method",
"batch_size_rows",
}
Expand Down
26 changes: 24 additions & 2 deletions tests/core/test_connector_sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,12 @@ def test_engine_json_serialization(self, connector: SQLConnector):
class TestDuckDBConnector:
@pytest.fixture
def connector(self):
return DuckDBConnector(config={"sqlalchemy_url": "duckdb:///"})
return DuckDBConnector(
config={
"sqlalchemy_url": "duckdb:///",
"allow_column_alter": True,
},
)

def test_create_schema(self, connector: DuckDBConnector):
engine = connector._engine
Expand All @@ -331,7 +336,6 @@ def test_column_rename(self, connector: DuckDBConnector):
assert result.keys() == ["id", "new_name"]

def test_adapt_column_type(self, connector: DuckDBConnector):
connector.allow_column_alter = True
engine = connector._engine
meta = sa.MetaData()
_ = sa.Table(
Expand All @@ -349,6 +353,24 @@ def test_adapt_column_type(self, connector: DuckDBConnector):
assert result.keys() == ["id", "name"]
assert result.cursor.description[1][1] == "STRING"

def test_adapt_column_type_not_allowed(self, connector: DuckDBConnector):
connector.config["allow_column_alter"] = False
engine = connector._engine
meta = sa.MetaData()
_ = sa.Table(
"test_table",
meta,
sa.Column("id", sa.Integer),
sa.Column("name", sa.Integer),
)
meta.create_all(engine)

with pytest.raises(
NotImplementedError,
match="Altering columns is not supported",
):
connector._adapt_column_type("test_table", "name", sa.types.String())


def test_adapter_without_json_serde():
registry.register(
Expand Down
Loading