feat: Stream sync context is now available to all instances methods as a Stream.context
attribute
#2529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some context on the design here:
context
parameter toRESTStream.get_new_paginator
is a breaking change. It could be handled by catching aTypeError
and retrying the call without the parameter, but this feels unnecessarily complicated.context
attribute to theStream
instance. It's only set when the sync starts and is wrapped byMappingProxyType
to discourage mutating the context object.context
parameter accepted by some methods a bit redundant, but I'm unsure whether it's worth deprecating and eventually removing it.📚 Documentation preview 📚: https://meltano-sdk--2529.org.readthedocs.build/en/2529/