Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use griffe to catch breaking API changes #2538

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 16, 2024

Closes #1565


📚 Documentation preview 📚: https://meltano-sdk--2538.org.readthedocs.build/en/2538/

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/chore/griffe branch 2 times, most recently from 5e54183 to c25bc74 Compare July 16, 2024 23:06
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/chore/griffe branch from c25bc74 to cb456de Compare July 16, 2024 23:07
Copy link

codspeed-hq bot commented Jul 16, 2024

CodSpeed Performance Report

Merging #2538 will not alter performance

Comparing edgarrmondragon/chore/griffe (cb456de) with main (8348456)

Summary

✅ 6 untouched benchmarks

@edgarrmondragon edgarrmondragon marked this pull request as ready for review July 16, 2024 23:08
@edgarrmondragon edgarrmondragon requested a review from a team as a code owner July 16, 2024 23:08
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.23%. Comparing base (33b2d4e) to head (cb456de).
Report is 148 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2538   +/-   ##
=======================================
  Coverage   89.23%   89.23%           
=======================================
  Files          54       54           
  Lines        4782     4782           
  Branches      935      935           
=======================================
  Hits         4267     4267           
  Misses        359      359           
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon merged commit b065e5e into main Jul 16, 2024
35 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/chore/griffe branch July 16, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider explicit __all__ declarations to reduce breakages on internal refactors
1 participant