Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make SQLSink a generic with a SQLConnector type parameter #2564

Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 25, 2024

Copy link

codspeed-hq bot commented Jul 25, 2024

CodSpeed Performance Report

Merging #2564 will not alter performance

Comparing edgarrmondragon/refactor/sql-sink-generic-connector (65e7e22) with main (e0197cd)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.47%. Comparing base (e0197cd) to head (65e7e22).
Report is 133 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2564   +/-   ##
=======================================
  Coverage   89.46%   89.47%           
=======================================
  Files          58       58           
  Lines        4795     4796    +1     
  Branches      937      937           
=======================================
+ Hits         4290     4291    +1     
  Misses        352      352           
  Partials      153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/sql-sink-generic-connector branch from 4b11720 to e82fdf5 Compare July 25, 2024 14:28
@edgarrmondragon edgarrmondragon marked this pull request as ready for review July 25, 2024 14:46
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/sql-sink-generic-connector branch from e82fdf5 to 65e7e22 Compare July 25, 2024 14:51
@edgarrmondragon edgarrmondragon merged commit 078cffd into main Jul 25, 2024
33 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/refactor/sql-sink-generic-connector branch July 25, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant