Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make it easier to switch Singer reader and writer IO implementations in plugin classes #2565

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 25, 2024

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/easy-switch-singer-reader-writer branch from 7434fbc to 53dd5d7 Compare July 25, 2024 15:36
Copy link

codspeed-hq bot commented Jul 25, 2024

CodSpeed Performance Report

Merging #2565 will not alter performance

Comparing edgarrmondragon/refactor/easy-switch-singer-reader-writer (53dd5d7) with main (078cffd)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.47%. Comparing base (078cffd) to head (53dd5d7).
Report is 132 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2565   +/-   ##
=======================================
  Coverage   89.47%   89.47%           
=======================================
  Files          58       58           
  Lines        4796     4799    +3     
  Branches      937      937           
=======================================
+ Hits         4291     4294    +3     
  Misses        352      352           
  Partials      153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review July 25, 2024 15:42
@edgarrmondragon edgarrmondragon merged commit 433b7fe into main Jul 25, 2024
34 of 35 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/refactor/easy-switch-singer-reader-writer branch July 25, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant