Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Date fields are now properly serialized as ISO dates, i.e. "YYYY-MM-DD" #2580

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 31, 2024

Copy link

codspeed-hq bot commented Jul 31, 2024

CodSpeed Performance Report

Merging #2580 will not alter performance

Comparing 1831-bug-json-serialization-of-date-types-causes-schema-validation-to-fail-in-target-postgres (32f2f87) with main (81d91f3)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.47%. Comparing base (81d91f3) to head (32f2f87).
Report is 117 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2580      +/-   ##
==========================================
- Coverage   89.51%   89.47%   -0.05%     
==========================================
  Files          58       58              
  Lines        4798     4798              
  Branches      936      936              
==========================================
- Hits         4295     4293       -2     
- Misses        350      352       +2     
  Partials      153      153              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review July 31, 2024 00:30
…uses-schema-validation-to-fail-in-target-postgres
@edgarrmondragon edgarrmondragon merged commit 87d78b3 into main Aug 6, 2024
35 checks passed
@edgarrmondragon edgarrmondragon deleted the 1831-bug-json-serialization-of-date-types-causes-schema-validation-to-fail-in-target-postgres branch August 6, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: JSON serialization of date types causes schema validation to fail in target-postgres
1 participant