Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Do not use poetry.lock in CI #2630

Closed
wants to merge 11 commits into from

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Aug 28, 2024

This unblocks removing the urllib3<2 constraint that we use due to python-poetry/poetry-plugin-export#176.


📚 Documentation preview 📚: https://meltano-sdk--2630.org.readthedocs.build/en/2630/

Copy link

codspeed-hq bot commented Aug 28, 2024

CodSpeed Performance Report

Merging #2630 will not alter performance

Comparing edgarrmondragon/chore/remove-poetry-lock (1c063e3) with main (2a3d3fa)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.67%. Comparing base (3de2b98) to head (1c063e3).
Report is 139 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2630   +/-   ##
=======================================
  Coverage   89.67%   89.67%           
=======================================
  Files          58       58           
  Lines        4854     4854           
  Branches      950      950           
=======================================
  Hits         4353     4353           
  Misses        350      350           
  Partials      151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/chore/remove-poetry-lock branch from 9a95d11 to df65324 Compare August 28, 2024 18:08
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/chore/remove-poetry-lock branch from 6c7fb86 to 4f36fa5 Compare August 28, 2024 18:20
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/chore/remove-poetry-lock branch from 4669f13 to 1874771 Compare August 28, 2024 18:26
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/chore/remove-poetry-lock branch from 0d2c592 to 4b0f0d1 Compare August 28, 2024 23:46
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/chore/remove-poetry-lock branch September 26, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant