-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(taps): Improved discovery performance for SQL taps #2793
Conversation
4818ea2
to
c0d33ab
Compare
CodSpeed Performance ReportMerging #2793 will improve performances by 36.49%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2793 +/- ##
==========================================
+ Coverage 91.24% 91.27% +0.02%
==========================================
Files 62 62
Lines 5188 5182 -6
Branches 670 669 -1
==========================================
- Hits 4734 4730 -4
+ Misses 321 319 -2
Partials 133 133 β View full report in Codecov by Sentry. |
b323742
to
14a5d5c
Compare
@@ -969,21 +1039,30 @@ def discover_catalog_entries(self) -> list[dict]: | |||
result: list[dict] = [] | |||
engine = self._engine | |||
inspected = sa.inspect(engine) | |||
object_kinds = ( | |||
(reflection.ObjectKind.TABLE, False), | |||
(reflection.ObjectKind.ANY_VIEW, True), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regression in MeltanoLabs/tap-postgres#528 was probably caused by ignoring views in the updated discovery process.
83a0731
to
6c69502
Compare
6c69502
to
6eaca46
Compare
TODO:
π Documentation preview π: https://meltano-sdk--2793.org.readthedocs.build/en/2793/