Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up Test Execution #2198

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

hegdeadithyak
Copy link

Description

Changed the Makefile and dependencies to use pytest-xdist

Fixes #797

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • make test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@CLAassistant
Copy link

CLAassistant commented Feb 9, 2025

CLA assistant check
All committers have signed the CLA.

@hegdeadithyak hegdeadithyak changed the title Modified Pytest to run across Multiple Workers Speed up Test Execution Feb 9, 2025
@hegdeadithyak
Copy link
Author

I used pytest-forked to avoid
RuntimeError: Storage folder /tmp/qdrant is already accessed by another instance of Qdra... ERROR tests/test_main.py::test_search[v1.1-True] - RuntimeError: Storage folder /tmp/qdrant is already accessed by another instance of Qdra... ERROR tests/test_main.py::test_add[v1.1-True] - RuntimeError: Storage folder /tmp/qdrant is already accessed by another instance of Qdra... ERROR tests/test_main.py::test_search[v1.0-False] - RuntimeError: Storage folder /tmp/qdrant is already accessed by another instance of Qdra... ERROR tests/test_main.py::test_get_all[v1.1-False-expected_result1] - RuntimeError: Storage folder /tmp/qdrant is already accessed by another instance of Qdra... ERROR tests/test_main.py::test_add[v1.0-False] - sqlite3.OperationalError: disk I/O error ERROR tests/test_main.py::test_get_all[v1.1-True-expected_result2] - sqlite3.OperationalError: disk I/O error ERROR tests/test_main.py::test_reset - sqlite3.OperationalError: disk I/O error ERROR tests/test_main.py::test_delete - sqlite3.OperationalError: disk I/O error
but looks like pytest-forked supports
image

@deshraj
Copy link
Collaborator

deshraj commented Feb 19, 2025

Thanks @hegdeadithyak. Can you please resolve conflicts?

@hegdeadithyak
Copy link
Author

hegdeadithyak commented Feb 23, 2025

Hey @deshraj , since poetry.lock is a generated file, I simply reverted it to the original version from the repo. Since anyway it will be regenrated by the workflow. Is it correct way to do it, just making sure I didn't miss anything,

Thanks,
K Adithya Hegde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up test execution
3 participants