Skip to content
CI

Use stable toolchain instead of 1.70 #55

Sign in to view logs

Use stable toolchain instead of 1.70

Use stable toolchain instead of 1.70 #55

GitHub Actions / clippy succeeded Dec 22, 2023 in 0s

clippy

5 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 5
Note 0
Help 0

Versions

  • rustc 1.74.1 (a28077b28 2023-12-04)
  • cargo 1.74.1 (ecb9851af 2023-10-18)
  • clippy 0.1.74 (a28077b 2023-12-04)

Annotations

Check warning on line 150 in src/process.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (10/7) 

warning: this function has too many arguments (10/7)
   --> src/process.rs:139:5
    |
139 | /     fn new(
140 | |         address: umem,
141 | |         pid: u32,
142 | |         state: PyProcessState,
...   |
149 | |         dtb2: umem,
150 | |     ) -> Self {
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
    = note: `#[warn(clippy::too_many_arguments)]` on by default

Check warning on line 59 in src/process.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `std::slice::ChunksExact<'_, u8>` 

warning: useless conversion to the same type: `std::slice::ChunksExact<'_, u8>`
  --> src/process.rs:57:35
   |
57 |                           return Ok(buf
   |  ___________________________________^
58 | |                             .chunks_exact(2)
59 | |                             .into_iter()
   | |________________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
help: consider removing `.into_iter()`
   |
57 ~                         return Ok(buf
58 +                             .chunks_exact(2)
   |

Check warning on line 173 in src/internal.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`usize` -> `usize`) 

warning: casting to the same type is unnecessary (`usize` -> `usize`)
   --> src/internal.rs:173:49
    |
173 |             InternalDT::Pointer(_, byteness) => *byteness as usize,
    |                                                 ^^^^^^^^^^^^^^^^^^ help: try: `*byteness`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
    = note: `#[warn(clippy::unnecessary_cast)]` on by default

Check warning on line 141 in src/internal.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

slow zero-filling initialization 

warning: slow zero-filling initialization
   --> src/internal.rs:141:17
    |
140 |                 let mut bytes = Vec::new();
    |                                 ---------- help: consider replacing this with: `vec![0; self.size()]`
141 |                 bytes.resize(self.size(), 0);
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization
    = note: `#[warn(clippy::slow_vector_initialization)]` on by default

Check warning on line 86 in src/internal.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `std::slice::Chunks<'_, u8>` 

warning: useless conversion to the same type: `std::slice::Chunks<'_, u8>`
  --> src/internal.rs:84:21
   |
84 | /                     bytes
85 | |                         .chunks(dt.size())
86 | |                         .into_iter()
   | |____________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
   = note: `#[warn(clippy::useless_conversion)]` on by default
help: consider removing `.into_iter()`
   |
84 ~                     bytes
85 +                         .chunks(dt.size())
   |
View more details on GitHub Actions