Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce image size #568

Merged
merged 45 commits into from
Mar 25, 2025
Merged

Reduce image size #568

merged 45 commits into from
Mar 25, 2025

Conversation

mattkjames7
Copy link
Contributor

@mattkjames7 mattkjames7 commented Mar 20, 2025

Description

Modified Dockerfiles in order to reduce image sizes on Docker Hub. Removed "dev" image, now each image will contain a script /make-dev-container.sh which will convert a running container into a "dev" container by downloading the toolchain and installing build dependencies.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • [Release note text]
  • Link the documentation PR here
    • [Documentation PR link]
  • Tag someone from docs team in the comments

@mattkjames7 mattkjames7 self-assigned this Mar 20, 2025
@mattkjames7 mattkjames7 added this to the mage-v3.1.1 milestone Mar 20, 2025
@mattkjames7 mattkjames7 added the Docs needed Docs needed label Mar 20, 2025
@mattkjames7 mattkjames7 requested a review from gitbuda March 21, 2025 15:32
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
14 Security Hotspots

See analysis details on SonarQube Cloud

@mattkjames7 mattkjames7 requested a review from DavIvek March 25, 2025 10:55
Copy link
Contributor

@imilinovic imilinovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String -> boolean inconsistencies I think otherwise good.

@mattkjames7 mattkjames7 enabled auto-merge March 25, 2025 11:25
@mattkjames7 mattkjames7 added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit 50bbfef Mar 25, 2025
9 of 10 checks passed
@mattkjames7 mattkjames7 deleted the reduce-image-size branch March 25, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants