Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Add Reviews 🚀 #97

Closed
wants to merge 14 commits into from
Closed

🚀 Add Reviews 🚀 #97

wants to merge 14 commits into from

Conversation

GamerBene19
Copy link
Collaborator

No description provided.

@GamerBene19 GamerBene19 force-pushed the reviews branch 2 times, most recently from cd2f092 to 11b76ba Compare July 21, 2022 14:59
Base automatically changed from prices-n-tags to main July 22, 2022 08:50
@netlify
Copy link

netlify bot commented Jul 22, 2022 •
edited
Loading

✅ Deploy Preview for mensatt ready!

Name Link
🔨 Latest commit 36bbfe0
🔍 Latest deploy log https://app.netlify.com/sites/mensatt/deploys/62ddb2c59537420008f19f32
😎 Deploy Preview https://deploy-preview-97--mensatt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@stormofice stormofice mentioned this pull request Jul 22, 2022
Closed
@GamerBene19 GamerBene19 force-pushed the reviews branch 2 times, most recently from 0ac667b to 8fbe232 Compare July 22, 2022 18:20
stormofice
stormofice requested changes Jul 23, 2022
View reviewed changes
Copy link
Contributor

@stormofice stormofice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the great contribution 😄

I am really pleased with the progress so far, but got some general questions regarding the changes and small nitpicks.

public/locales/de/common.json Show resolved Hide resolved
public/locales/de/common.json Outdated Show resolved Hide resolved
public/locales/en/common.json Show resolved Hide resolved
src/components/occurrence/Occurrence.tsx Show resolved Hide resolved
src/components/occurrence/Occurrence.tsx Outdated Show resolved Hide resolved
src/components/occurrence/Occurrence.tsx Show resolved Hide resolved
src/components/occurrence/Occurrence.tsx Show resolved Hide resolved
src/components/occurrence/review-modal/ReviewModal.tsx Show resolved Hide resolved
src/components/occurrence/review-modal/ReviewModal.tsx Outdated Show resolved Hide resolved
@stormofice stormofice added the enhancement New feature or request label Jul 23, 2022
@GamerBene19 GamerBene19 requested a review from stormofice July 24, 2022 08:58
@GamerBene19 GamerBene19 force-pushed the reviews branch 2 times, most recently from 094de21 to df48661 Compare July 24, 2022 13:22
@GamerBene19 GamerBene19 changed the base branch from main to license July 24, 2022 13:23
stormofice
stormofice previously approved these changes Jul 24, 2022
View reviewed changes
Copy link
Contributor

@stormofice stormofice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, approved!

Base automatically changed from license to main July 24, 2022 19:17
@GamerBene19 GamerBene19 force-pushed the reviews branch 2 times, most recently from 40ee976 to 87086ed Compare July 24, 2022 19:42
@GamerBene19 GamerBene19 marked this pull request as draft July 24, 2022 20:55
@GamerBene19
Copy link
Collaborator Author

Is/Will be implemented in seperate PRs

@GamerBene19 GamerBene19 deleted the reviews branch July 27, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maanex maanex maanex left review comments

@stormofice stormofice stormofice left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GamerBene19 @maanex @stormofice