Open resolve links #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my Linux system opening "/proc" with out any flags works just fine.
Additionally this restriction prevents using resolve_path on the
virtual proc file system.
The following code snippets works without an error on Linux.
#include <err.h>
#include <fcntl.h>
#include <stdlib.h>
int main() {
int fd = open("/proc", 0, 0);
if (fd < 0) {
err(EXIT_FAILURE, "opening /proc failed\n");
}
return 0;
}
Symbolic links are much more usefull if we do not have to take care of them maually. Use resolve_path and FOLLOW_LINKS when opening files using vfs_open. Additionally, the directory check is not needed because calling read(2) on a directory should return -1 and set errno to EISDIR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #40, I think symbolic links are only useful if they need no manual resolution.
This PR resolves all symbolic links in
vfs_open.All additional changes are requirements or simplifications.