set procfs file masks #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The procfs_file_t struct contains a mask member which was never used. Use the mask member in __procfs_stat and allow to set it using proc_entry_set_mask via the contained procfs entry.
The directory /proc/ipc has the permissions r-xr-xr-x. Set the permissions of all entries in /proc/ipc to r--r--r--. Use a loop to create all entries removing code duplication.
Remove the duplicated code by using a loop to create the entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all entries in the proc file system report
0000as mask.Address this issue by using the
maskmember included in theprocfs_file_tstruct and setting it accordingly via the new functionproc_entry_set_mask.Additionally, use loops to create some entries removing code duplication.
Before
After