Consider local keybindings when moving commands for the Motion state. #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for the contribution. We want to keep meow free of dependencies, so we don't want to introduce |
Instead of directly binding `H-j` to what was bound to `j`, for example, bind `H-j` to an interactive lambda which first checks whether there is a local binding for `j`. If there is, use that. If there is not, then call the orignal command bound to `j`. This should fix using the overrides in Magit buffers (see meow-edit#493), where the command bound to `H-k` seems to be based on where point is located when `meow--save-origin-commands` is run.
|
OK, I've removed the use of Compat and copied the relevant portion of the definition. This change works for me on Emacs 29.1. What else would you like changed? |
|
I'm quite busy these days. Later I'll check the updates and merge. |
|
@DogLooksGood This works for me. Will you merge it? |
|
I'll do some test and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the library Compat (https://elpa.gnu.org/packages/compat.html), which makes available the function
keymap-local-lookupto Emacs older than 29.1. The newkeymap-functions are recommended over older functions likelookup-key.Instead of directly binding
H-jto what was bound toj, for example, bindH-jto an interactive lambda which first checks whether there is a local binding forj. If there is, use that. If there is not, then call the orignal command bound toj.This seems to fix using the overrides in Magit buffers (see #493), where the command bound to
H-kseems to be based on where point is located whenmeow--save-origin-commandsis run.