Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to actions/github-script Github Action #101

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Migrate to actions/github-script Github Action #101

merged 2 commits into from
Jun 30, 2023

Conversation

rustycl0ck
Copy link
Contributor

@rustycl0ck rustycl0ck commented Jun 16, 2023 •
edited
Loading

The currently used actions-ecosystem/action-remove-labels and
actions-ecosystem/action-add-labels seem unmaintained and don't work
anymore because of using deprecated Nodejs 12 version.

Therefore, migrate to a better maintained solution.

@github-actions github-actions bot added the bug Something isn't working label Jun 16, 2023
@rustycl0ck rustycl0ck added size/XXL and removed bug Something isn't working labels Jun 16, 2023
@github-actions github-actions bot added bug Something isn't working size/M and removed size/XXL bug Something isn't working labels Jun 16, 2023
@rustycl0ck rustycl0ck added bug Something isn't working and removed size/M labels Jun 16, 2023
@github-actions github-actions bot added size/M and removed bug Something isn't working labels Jun 16, 2023
@rustycl0ck rustycl0ck added bug Something isn't working duplicate This issue or pull request already exists size/XS size/L size/XL labels Jun 16, 2023
@rustycl0ck rustycl0ck added size/XXL and removed bug Something isn't working duplicate This issue or pull request already exists size/M size/XXL labels Jun 16, 2023
@rustycl0ck rustycl0ck removed the size/M label Jun 16, 2023
@rustycl0ck
Copy link
Contributor Author

^ Sorry there are too many label additions/removals because I was checking whether it works correctly or not.
Current functionality:
Any existing size/* labels (matching defaults) are removed and only the final determined size label is applied. All the other labels remain untouched.

@rustycl0ck rustycl0ck marked this pull request as ready for review June 16, 2023 08:18
@rustycl0ck rustycl0ck requested a review from a team as a code owner June 16, 2023 08:18
@rustycl0ck rustycl0ck enabled auto-merge (squash) June 16, 2023 08:18
@rustycl0ck rustycl0ck requested a review from tkuchiki June 19, 2023 04:12
@tkuchiki tkuchiki added bug Something isn't working size/S labels Jun 30, 2023
@github-actions github-actions bot removed the size/S label Jun 30, 2023
@rustycl0ck rustycl0ck added size/XL and removed size/M labels Jun 30, 2023
@github-actions github-actions bot added size/M and removed size/XL labels Jun 30, 2023
@rustycl0ck
Add 'continue-on-error'
4fbc925 
Signed-off-by: rustyclock <[email protected]>
@rustycl0ck rustycl0ck removed the bug Something isn't working label Jun 30, 2023
tkuchiki
tkuchiki approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@tkuchiki tkuchiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rustycl0ck rustycl0ck merged commit 8e8ee06 into master Jun 30, 2023
@rustycl0ck rustycl0ck deleted the add-dependabot branch June 30, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkuchiki tkuchiki tkuchiki approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rustycl0ck @tkuchiki