Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implicit selection of dialogue graph #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Vrixyz
Copy link

@Vrixyz Vrixyz commented Dec 7, 2019

Hello,

I thought the save/load process might benefit some improvements, such as being closer to the one of the "Animation" Window, so this pull request does a few tweaks to the loading/saving process.

quick changelog:

  • The "Narrative graph" load the selected asset graph from project selection
  • The title changes to reflect current selection to avoid doubt on which file is selected
    • this idea is from major code editors, where we could also add an asterisk * if there's modifications to be saved.
    • modifying title is not very unity-esque so I'm less sure now...
  • no "Load" anymore
  • "save" and "new" dialogue file process reworked to use unity file selector

@merpheus-dev
Copy link
Owner

merpheus-dev commented Dec 8, 2019

Hey there! Thanks for the PR! Looks good.

Although, when I test it I got some errors while creating a new narrative as follows. If you can take a look at it. That would be great 👍

ArgumentException: This visualElement is not my child
UnityEngine.UIElements.VisualElement+Hierarchy.Remove (UnityEngine.UIElements.VisualElement child) (at C:/buildslave/unity/build/Modules/UIElements/VisualElementHierarchy.cs:304)
UnityEngine.UIElements.VisualElement.Remove (UnityEngine.UIElements.VisualElement element) (at C:/buildslave/unity/build/Modules/UIElements/VisualElementHierarchy.cs:108)
Subtegral.DialogueSystem.Editor.StoryGraph.OnDisable () (at Library/PackageCache/com.subtegral.dialoguesystem@dd88cc6595be1c89f00a67dc1c0179ba695f791b/com.subtegral.dialoguesystem/Editor/Graph/StoryGraph.cs:124)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr)

@Vrixyz
Copy link
Author

Vrixyz commented Dec 8, 2019

I was on unity 2.9 if that’s of any help, I’ll take a look at your error when possible!

@Vrixyz
Copy link
Author

Vrixyz commented Dec 14, 2019

Well indeed this PR needs more work, after a fresh install on mac, it had problem saving narrative files.

Well, I doubt I'll do more work on this Pull Request any time soon, thanks for your time :)

@merpheus-dev
Copy link
Owner

No worries! I'll probably edit your PR and push it when I do. Thanks for your great contribution Thierry! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants