Revert serial

[Hunter275]

Revert serial

[benbrown]

I am learning from reading the commit history -- why did this happen?

[nmaq-dev]

I have the same question! Why???

I've spent the last few hours trying to figure out how to accomplish this.

I ran across this issue in the python code meshtastic/python#74 which brought me here. I had looked in this repo for anything that was server-attached instead of browser-attached.

[benbrown]

@nmaq-dev The reason is that bundling the node dependencies causes issues when used in a browser unless you do extra build steps yourself which is a recipe for pain. I have some PRs open around this, but I think the likely path forward will be a separate module to handle nodejs connections rather than including them both in this package.

[benbrown]

@nmaq-dev this branch has a working node implementation #119

[nmaq-dev]

Thanks for that 🙇

I'll poke at things. I started on the python side of things because I know it far better than js/ts/node. I can give it a shot and see if I can contribute any thoughts.

[Hunter275]

@nmaq-dev The reason is that bundling the node dependencies causes issues when used in a browser unless you do extra build steps yourself which is a recipe for pain. I have some PRs open around this, but I think the likely path forward will be a separate module to handle nodejs connections rather than including them both in this package.

Exactly this.

[benbrown]

@Hunter275 glad I got it right. I've got the working node class, I just need to bundle it up into a separate package.